Fix Ptest for Cython.#16915
Open
AkarshHCL wants to merge 4 commits intomicrosoft:3.0-devfrom
Open
Conversation
microsoft-github-policy-service
Bot
added
Packaging
3.0-dev
Contributor
Contributor
Author
|
Buddy build is successful .It had license warnings which I have resolved now. |
Contributor
Contributor
Author
|
Buddy build is successful with no license warnings. |
Kanishk-Bansal
requested changes
Apr 29, 2026
Contributor
Kanishk-Bansal
left a comment
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Overly broad sed — sed -i '/\$/s/\$//' Cython/Build/IpythonMagic.py strips the trailing backslash from every line ending in , not only the E502 (redundant-backslash-between-brackets) cases. Legitimate Python line continuations elsewhere in the file would also be silently rewritten.
just change in IpythonMagic.py using a patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
The Cython test suite was failing during %check due to a code formatting violation reported by the upstream style checker (TestCodeFormat). The failure specifically originated from a flake8 error:
E502: redundant backslash between brackets
File affected: Cython/Build/IpythonMagic.py
This issue is purely a style/linting problem and does not impact build correctness or runtime functionality. However, since the upstream test suite enforces formatting checks, it caused the overall test execution to fail.
To resolve this we applied a targeted in-place fix during the %check phase using a sed command. This removes trailing backslashes from affected lines, eliminating the E502 violation
Change Log
Does this affect the toolchain?
Yes
Test Methodology